DC/dc-project
1
1
Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Lint

Browse Source
This commit is contained in:
Fabrice Lecomte
2020-03-17 01:34:30 +01:00
parent 676baa4e28
commit f225f7345c
3 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/kotlin/feature/CitizenSteps.kt
View File

@@ -16,8 +16,8 @@ class CitizenSteps : En, KoinTest {
Given("I have citizen") { extraData: DataTable? -> Given("I have citizen") { extraData: DataTable? ->
val params = extraData?.asMap<String, String>(String::class.java, String::class.java) val params = extraData?.asMap<String, String>(String::class.java, String::class.java)
createCitizen( createCitizen(
params?.get("firstName") ?: "firstName"+UUID.randomUUID(), params?.get("firstName") ?: "firstName" + UUID.randomUUID(),
params?.get("lastName") ?: "lastName"+UUID.randomUUID(), params?.get("lastName") ?: "lastName" + UUID.randomUUID(),
extraData extraData
) )
} }
@@ -31,11 +31,11 @@ class CitizenSteps : En, KoinTest {
} }
} }
private fun createCitizen (firstName: String, lastName: String, extraData: DataTable? = null, id: UUID? = null) { private fun createCitizen(firstName: String, lastName: String, extraData: DataTable? = null, id: UUID? = null) {
val params = extraData?.asMap<String, String>(String::class.java, String::class.java) val params = extraData?.asMap<String, String>(String::class.java, String::class.java)
val id: UUID = id ?: params?.get("id")?.let { UUID.fromString(it) } ?: UUID.randomUUID() val id: UUID = id ?: params?.get("id")?.let { UUID.fromString(it) } ?: UUID.randomUUID()
val email = params?.get("email") ?: ("$firstName-$lastName".toLowerCase()) + "@dc-project.fr" val email = params?.get("email") ?: ("$firstName-$lastName".toLowerCase()) + "@dc-project.fr"
val user = User( val user = User(
id = id, id = id,

20
src/test/kotlin/feature/ConstitutionSteps.kt
View File

@@ -41,14 +41,14 @@ class ConstitutionSteps : En, KoinTest {
private fun createConstitution(extraData: DataTable? = null, id: UUID? = null) { private fun createConstitution(extraData: DataTable? = null, id: UUID? = null) {
val params = extraData?.asMap<String, String>(String::class.java, String::class.java) val params = extraData?.asMap<String, String>(String::class.java, String::class.java)
val createdByUsername = params?.get("createdBy") val createdByUsername = params?.get("createdBy")
val username = (createdByUsername ?: "username"+UUID.randomUUID().toString()) val username = (createdByUsername ?: "username" + UUID.randomUUID().toString())
.toLowerCase().replace(' ', '-') .toLowerCase().replace(' ', '-')
val createdBy = if (createdByUsername != null) { val createdBy = if (createdByUsername != null) {
get<CitizenRepository>().findByUsername(username) ?: error("Citizen not exist") get<CitizenRepository>().findByUsername(username) ?: error("Citizen not exist")
} else { } else {
val first = "firstName"+UUID.randomUUID().toString() val first = "firstName" + UUID.randomUUID().toString()
val last = "lastName"+UUID.randomUUID().toString() val last = "lastName" + UUID.randomUUID().toString()
Citizen( Citizen(
birthday = DateTime.now(), birthday = DateTime.now(),
name = CitizenI.Name( name = CitizenI.Name(
@@ -76,12 +76,20 @@ class ConstitutionSteps : En, KoinTest {
get<ConstitutionRepository>().upsert(constitution) get<ConstitutionRepository>().upsert(constitution)
} }
private fun commentConstitution(constitutionId: String, firstName: String, lastName: String, extraData: DataTable? = null) { private fun commentConstitution(
constitutionId: String,
firstName: String,
lastName: String,
extraData: DataTable? = null
) {
val params = extraData?.asMap<String, String>(String::class.java, String::class.java) val params = extraData?.asMap<String, String>(String::class.java, String::class.java)
val constitution = get<ConstitutionRepository>().findById(UUID.fromString(constitutionId)) ?: error("Constitution not exist") val constitution =
get<ConstitutionRepository>().findById(UUID.fromString(constitutionId)) ?: error("Constitution not exist")
val citizen = get<CitizenRepository>().findByUsername(("$firstName-$lastName".toLowerCase()).toLowerCase().replace(' ', '-')) ?: error("Citizen not exist") val citizen = get<CitizenRepository>().findByUsername(
("$firstName-$lastName".toLowerCase()).toLowerCase().replace(' ', '-')
) ?: error("Citizen not exist")
val comment: CommentEntity<ConstitutionRef> = CommentEntity( val comment: CommentEntity<ConstitutionRef> = CommentEntity(
id = params?.get("id")?.let { UUID.fromString(it) } ?: UUID.randomUUID(), id = params?.get("id")?.let { UUID.fromString(it) } ?: UUID.randomUUID(),

1
src/test/kotlin/fr/dcproject/security/voter/ArticleVoterTest.kt
View File

@@ -50,7 +50,6 @@ internal class ArticleVoterTest {
@Test @Test
fun `other user can be view the article`() = ArticleVoter().run { fun `other user can be view the article`() = ArticleVoter().run {
val article = getArticle(tesla) val article = getArticle(tesla)
val article2 = getArticle(tesla)
mockk<ApplicationCall> { mockk<ApplicationCall> {
every { user } returns einstein.user every { user } returns einstein.user