improve sonarqube action

.github/workflows/tests.yml

@@ -126,11 +126,20 @@ jobs:
         key: ${{ runner.os }}-sonar
         restore-keys: ${{ runner.os }}-sonar
 
+    - name: Test
+      uses: eskatos/gradle-command-action@v1
+      with:
+        gradle-version: 6.8
+        arguments: test
+
     - name: Build and analyze
+      uses: eskatos/gradle-command-action@v1
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-      run: ./gradlew build sonarqube --info
+      with:
+        gradle-version: 6.8
+        arguments: sonarqube --info
 
   lint:
     needs: build

build.gradle.kts

@@ -181,8 +181,6 @@ tasks.named<ShadowJar>("shadowJar") {
 }
 
 tasks.sonarqube.configure {
-    dependsOn(tasks.test)
-    dependsOn(tasks.detekt)
     dependsOn(tasks.jacocoTestReport)
 }
 
@@ -313,6 +311,7 @@ tasks.register("testWithDependencies", Test::class) {
     dependsOn(tasks.named("testComposeUp"))
     dependsOn(tasks.ktlintCheck)
     dependsOn(testSql)
+    finalizedBy(tasks.sonarqube) // report is always generated after tests run
 }
 tasks.register("testArticles", Test::class) {
     group = "tests"

src/main/kotlin/fr/dcproject/common/validation/Url.kt

@@ -7,7 +7,7 @@ import java.net.URL
 fun ValidationBuilder<String>.isUrl() =
     addConstraint("is not url") {
         try {
-            val url = URL(it)
+            URL(it)
             true
         } catch (e: MalformedURLException) {
             false