Lint

src/main/kotlin/application/Converters.kt

@@ -1,14 +1,6 @@
 package fr.dcproject.application
 
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenBasic
-import fr.dcproject.component.citizen.CitizenRef
-import fr.dcproject.component.citizen.CitizenRepository
-import fr.dcproject.component.constitution.Constitution
-import fr.dcproject.component.constitution.ConstitutionRef
-import fr.dcproject.component.constitution.ConstitutionRepository
-import fr.dcproject.component.opinion.OpinionChoiceRepository
-import fr.dcproject.component.opinion.entity.OpinionChoice
 import fr.dcproject.component.workgroup.Workgroup
 import fr.dcproject.component.workgroup.WorkgroupRef
 import fr.dcproject.component.workgroup.WorkgroupRepository

src/main/kotlin/component/article/routes/UpsertArticle.kt

@@ -17,7 +17,6 @@ import io.ktor.application.call
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/auth/routes/Login.kt

@@ -10,7 +10,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.response.respondText
 import io.ktor.routing.Route

src/main/kotlin/component/auth/routes/Register.kt

@@ -15,7 +15,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.response.respondText
 import io.ktor.routing.Route

src/main/kotlin/component/auth/routes/Sso.kt

@@ -8,7 +8,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 

src/main/kotlin/component/citizen/routes/ChangeMyPassword.kt

@@ -1,10 +1,8 @@
 package fr.dcproject.component.citizen.routes
 
-import com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException
 import fr.dcproject.component.auth.UserRepository
 import fr.dcproject.component.auth.citizen
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenAccessControl
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.security.assert
@@ -16,8 +14,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
-import io.ktor.request.receiveOrNull
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/citizen/routes/GetOneCitizen.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.citizen.routes
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenAccessControl
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.citizen.CitizenRepository

src/main/kotlin/component/comment/article/routes/CreateCommentArticle.kt

@@ -15,7 +15,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/comment/article/routes/GetCitizenArticleComments.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.comment.article.routes
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.comment.article.CommentArticleRepository
 import fr.dcproject.component.comment.generic.CommentAccessControl

src/main/kotlin/component/comment/constitution/routes/GetCitizenCommentConstitution.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.comment.constitution.routes
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.comment.constitution.CommentConstitutionRepository
 import fr.dcproject.component.comment.generic.CommentAccessControl

src/main/kotlin/component/comment/generic/routes/CreateCommentChildren.kt

@@ -14,7 +14,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/constitution/ConstitutionAccessControl.kt

@@ -15,7 +15,7 @@ class ConstitutionAccessControl : AccessControl() {
     fun <S : ConstitutionSimple<*, *>> canView(subjects: List<S>, citizen: CitizenI?): AccessResponse =
         canAll(subjects) { canView(it, citizen) }
 
-    fun <S> canView(subject: S, citizen: CitizenI?): AccessResponse where S: EntityDeletedAt, S: ConstitutionS = when {
+    fun <S> canView(subject: S, citizen: CitizenI?): AccessResponse where S : EntityDeletedAt, S : ConstitutionS = when {
         subject.isDeleted() -> denied("You cannot view a deleted constitution", "constitution.view.deleted")
         else -> granted()
     }

src/main/kotlin/component/constitution/routes/CreateConstitution.kt

@@ -18,7 +18,6 @@ import io.ktor.application.call
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/follow/routes/article/GetMyFollowsArticle.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.follow.routes.article
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.follow.FollowAccessControl
 import fr.dcproject.component.follow.FollowArticleRepository

src/main/kotlin/component/opinion/OpinionAccessControl.kt

@@ -1,9 +1,7 @@
 package fr.dcproject.component.opinion
 
 import fr.dcproject.common.entity.HasTarget
-import fr.dcproject.common.entity.TargetRef
 import fr.dcproject.component.citizen.CitizenI
-import fr.dcproject.component.opinion.entity.Opinion
 import fr.dcproject.component.opinion.entity.OpinionI
 import fr.dcproject.security.AccessControl
 import fr.dcproject.security.AccessResponse
@@ -24,10 +22,10 @@ class OpinionAccessControl : AccessControl() {
         }
     }
 
-    fun <S, SS : List<S>, C: CitizenI> canView(subjects: SS, citizen: CitizenI?): AccessResponse where S : OpinionI, S : EntityCreatedBy<C> =
+    fun <S, SS : List<S>, C : CitizenI> canView(subjects: SS, citizen: CitizenI?): AccessResponse where S : OpinionI, S : EntityCreatedBy<C> =
         canAll(subjects) { canView(it, citizen) }
 
-    fun <S, C: CitizenI> canView(subject: S, citizen: CitizenI?): AccessResponse where S : OpinionI, S : EntityCreatedBy<C> = when {
+    fun <S, C : CitizenI> canView(subject: S, citizen: CitizenI?): AccessResponse where S : OpinionI, S : EntityCreatedBy<C> = when {
         citizen == null -> denied("You must be connected to delete opinion", "opinion.delete.notConnected")
         subject.createdBy.id != citizen.id -> denied("You cannot view opinions of other citizen", "opinion.view.otherCitizen")
         else -> granted()

src/main/kotlin/component/opinion/OpinionChoiceAccessControl.kt

@@ -1,9 +1,7 @@
 package fr.dcproject.component.opinion
 
 import fr.dcproject.component.citizen.CitizenI
-import fr.dcproject.component.opinion.entity.OpinionChoice
 import fr.dcproject.component.opinion.entity.OpinionChoiceI
-import fr.dcproject.component.opinion.entity.OpinionChoiceRef
 import fr.dcproject.security.AccessControl
 import fr.dcproject.security.AccessResponse
 

src/main/kotlin/component/opinion/routes/GetCitizenOpinions.kt

@@ -13,9 +13,7 @@ import io.ktor.locations.Location
 import io.ktor.locations.get
 import io.ktor.response.respond
 import io.ktor.routing.Route
-import org.koin.core.KoinComponent
 import java.util.UUID
-import fr.dcproject.component.citizen.Citizen as CitizenEntity
 import fr.dcproject.component.opinion.OpinionRepositoryArticle as OpinionArticleRepository
 
 @KtorExperimentalLocationsAPI

src/main/kotlin/component/opinion/routes/GetMyOpinionsArticle.kt

@@ -3,7 +3,6 @@ package fr.dcproject.component.opinion.routes
 import fr.dcproject.common.entity.TargetRef
 import fr.dcproject.component.auth.citizen
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.CitizenBasicI
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.opinion.OpinionAccessControl
 import fr.dcproject.component.opinion.entity.Opinion
@@ -17,8 +16,8 @@ import io.ktor.locations.Location
 import io.ktor.locations.get
 import io.ktor.response.respond
 import io.ktor.routing.Route
-import fr.dcproject.component.opinion.OpinionRepositoryArticle as OpinionArticleRepository
 import java.util.UUID
+import fr.dcproject.component.opinion.OpinionRepositoryArticle as OpinionArticleRepository
 
 @KtorExperimentalLocationsAPI
 object GetMyOpinionsArticle {

src/main/kotlin/component/opinion/routes/GetOpinionChoices.kt

@@ -4,6 +4,7 @@ import fr.dcproject.component.auth.citizenOrNull
 import fr.dcproject.component.opinion.OpinionChoiceAccessControl
 import fr.dcproject.component.opinion.OpinionChoiceRepository
 import fr.dcproject.security.assert
+import fr.dcproject.utils.toUUID
 import io.ktor.application.call
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location

src/main/kotlin/component/opinion/routes/OpinionArticle.kt

@@ -14,7 +14,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/vote/routes/GetCitizenVotes.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.vote.routes
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.vote.VoteAccessControl
 import fr.dcproject.component.vote.VoteRepository

src/main/kotlin/component/vote/routes/GetCitizenVotesOnArticle.kt

@@ -1,7 +1,6 @@
 package fr.dcproject.component.vote.routes
 
 import fr.dcproject.component.auth.citizenOrNull
-import fr.dcproject.component.citizen.Citizen
 import fr.dcproject.component.citizen.CitizenRef
 import fr.dcproject.component.vote.VoteAccessControl
 import fr.dcproject.component.vote.VoteArticleRepository

src/main/kotlin/component/vote/routes/PutVoteOnArticle.kt

@@ -15,7 +15,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/vote/routes/PutVoteOnComment.kt

@@ -13,7 +13,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/vote/routes/VoteConstitution.kt

@@ -16,10 +16,8 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
-import fr.dcproject.component.constitution.Constitution as ConstitutionEntity
 import java.util.UUID
 
 @KtorExperimentalLocationsAPI

src/main/kotlin/component/workgroup/routes/CreateWorkgroup.kt

@@ -13,7 +13,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import java.util.UUID

src/main/kotlin/component/workgroup/routes/EditWorkgroup.kt

@@ -11,7 +11,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import org.koin.core.KoinComponent

src/main/kotlin/component/workgroup/routes/members/AddMemberToWorkgroup.kt

@@ -13,7 +13,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.post
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import org.koin.core.KoinComponent

src/main/kotlin/component/workgroup/routes/members/DeleteMembersOfWorkgroup.kt

@@ -13,7 +13,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.delete
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import org.koin.core.KoinComponent

src/main/kotlin/component/workgroup/routes/members/UpdateMemberOfWorkgroup.kt

@@ -13,7 +13,6 @@ import io.ktor.http.HttpStatusCode
 import io.ktor.locations.KtorExperimentalLocationsAPI
 import io.ktor.locations.Location
 import io.ktor.locations.put
-import io.ktor.request.receive
 import io.ktor.response.respond
 import io.ktor.routing.Route
 import org.koin.core.KoinComponent

src/main/kotlin/utils/Request.kt

@@ -5,21 +5,19 @@ import io.ktor.application.ApplicationCall
 import io.ktor.application.log
 import io.ktor.features.BadRequestException
 import io.ktor.request.receive
-import kotlin.reflect.KType
 import kotlin.reflect.typeOf
 
-
 /**
  * Receives content for this request.
  * @param type instance of `KClass` specifying type to be received.
  * @return instance of [T] received from this call, or `null` if content cannot be transformed to the requested type..
  */
 @OptIn(ExperimentalStdlibApi::class)
-public suspend inline fun <reified T : Any>  ApplicationCall.receiveOrBadRequest(message: String = "Bad Request, wrong body request"): T {
+public suspend inline fun <reified T : Any> ApplicationCall.receiveOrBadRequest(message: String = "Bad Request, wrong body request"): T {
     return try {
         receive<T>(typeOf<T>())
     } catch (cause: MissingKotlinParameterException) {
         application.log.debug("Conversion failed, throw bad exeption", cause)
         throw BadRequestException(message, cause)
     }
-}
+}