#42 Add tests for WorkgroupVoter

src/main/kotlin/fr/dcproject/entity/Workgroup.kt

@@ -6,7 +6,7 @@ import fr.postgresjson.entity.mutable.EntityDeletedAtImp
 import java.util.*
 
 class Workgroup(
-    id: UUID?,
+    id: UUID? = null,
     name: String,
     description: String,
     logo: String? = null,
@@ -28,7 +28,7 @@ class Workgroup(
     EntityUpdatedAt by EntityUpdatedAtImp()
 
 open class WorkgroupSimple<Z : CitizenRef>(
-    id: UUID?,
+    id: UUID? = null,
     var name: String,
     var description: String,
     var logo: String? = null,
@@ -40,7 +40,7 @@ open class WorkgroupSimple<Z : CitizenRef>(
     EntityDeletedAt by EntityDeletedAtImp()
 
 open class WorkgroupRef(
-    id: UUID?
+    id: UUID? = null
 ) : UuidEntity(id ?: UUID.randomUUID()), WorkgroupI
 
 interface WorkgroupWithAuthI<Z : CitizenWithUserI> : WorkgroupWithMembersI<Z>, EntityCreatedBy<Z>, EntityDeletedAt {

src/main/kotlin/fr/dcproject/security/voter/WorkgroupVoter.kt

@@ -15,7 +15,7 @@ class WorkgroupVoter : Voter {
 
     override fun supports(action: ActionI, call: ApplicationCall, subject: Any?): Boolean {
         return (action is Action)
-            .and(subject is List<*> || subject is WorkgroupI?)
+            .and(subject is WorkgroupI?)
     }
 
     override fun vote(action: ActionI, call: ApplicationCall, subject: Any?): Vote {
@@ -31,14 +31,6 @@ class WorkgroupVoter : Voter {
                 else if (subject.anonymous && user != null && subject.isMember(user)) Vote.GRANTED
                 else Vote.DENIED
             }
-            if (subject is List<*>) {
-                subject.forEach {
-                    if (it !is WorkgroupWithAuthI<*> || it.isDeleted()) {
-                        return Vote.DENIED
-                    }
-                }
-                return Vote.GRANTED
-            }
             return Vote.DENIED
         }
 
@@ -52,10 +44,9 @@ class WorkgroupVoter : Voter {
             }
 
             return Vote.DENIED
-        }
-
-        if (action is Action) {
-            return Vote.DENIED
+        } else if (subject !is WorkgroupWithAuthI<*> && (action == Action.DELETE || action == Action.UPDATE)) {
+            throw object :
+                VoterException("Unable to define if your are granted, the subject must implement 'WorkgroupWithAuthI'") {}
         }
 
         return Vote.ABSTAIN