DC/dc-project
1
1
Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

refactoring: replace procedure find_user_by_* to function

Browse Source
This commit is contained in:
Fabrice Lecomte
2019-07-26 16:18:31 +02:00
parent fc06965cda
commit 4ce81c6210
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
resources/functions/user/find_user_by_id.sql
View File

@@ -1,4 +1,4 @@
create or replace procedure find_user_by_id(in id uuid, inout resource json) language plpgsql as create or replace function find_user_by_id(in id uuid, out resource json) language plpgsql as
$$ $$
declare declare
_id alias for id; _id alias for id;
@@ -9,4 +9,4 @@ begin
end; end;
$$; $$;
-- drop procedure if exists find_user_by_id(uuid, inout json); -- drop function if exists find_user_by_id(uuid, inout json);

4
resources/functions/user/find_user_by_username.sql
View File

@@ -1,4 +1,4 @@
create or replace procedure find_user_by_username(in username text, inout resource json) language plpgsql as create or replace function find_user_by_username(in username text, out resource json) language plpgsql as
$$ $$
declare declare
_username alias for username; _username alias for username;
@@ -9,4 +9,4 @@ begin
end; end;
$$; $$;
-- drop procedure if exists find_user_by_username(text, inout json); -- drop function if exists find_user_by_username(text, out json);

6
resources/tests/user.sql
View File

@@ -11,11 +11,11 @@ begin
assert created_user->>'password' is not null, 'password must be generated'; assert created_user->>'password' is not null, 'password must be generated';
-- get user by there id and check the username is correct -- get user by there id and check the username is correct
call find_user_by_id((created_user->>'id')::uuid, selected_user); select find_user_by_id((created_user->>'id')::uuid) into selected_user;
assert selected_user->>'username' = 'george', 'username must be george'; assert selected_user->>'username' = 'george', format('username must be george, %s instead', selected_user);
-- get user by username and check the username is correct -- get user by username and check the username is correct
call find_user_by_username(created_user->>'username', selected_user); select find_user_by_username(created_user->>'username') into selected_user;
assert selected_user->>'username' = 'george', 'username must be george'; assert selected_user->>'username' = 'george', 'username must be george';
-- check if user exist with username and password and verify the reterned user -- check if user exist with username and password and verify the reterned user