DC/dc-project
1
1
Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

#42 Improve CommentVoter

Browse Source
This commit is contained in:
Fabrice Lecomte
2020-03-17 15:14:44 +01:00
parent 890c84c762
commit 4b96080051
2 changed files with 51 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/kotlin/fr/dcproject/security/voter/CommentVoter.kt
View File

@@ -18,19 +18,27 @@ class CommentVoter : Voter {
override fun vote(action: ActionI, call: ApplicationCall, subject: Any?): Vote {
val user = call.user
if (action == Action.CREATE && user != null) {
if (subject !is Comment<*> ) {
return Vote.DENIED
}
if (action == Action.CREATE) {
if (user == null) {
return Vote.DENIED
}
if (subject.createdBy.user.id != user.id) {
return Vote.DENIED
}
return Vote.GRANTED
}
if (action == Action.VIEW) {
if (subject is Comment<*>) {
return if (subject.isDeleted()) Vote.DENIED
else Vote.GRANTED
}
return Vote.DENIED
return if (subject.isDeleted()) Vote.DENIED
else Vote.GRANTED
}
if (action == Action.UPDATE && user != null && subject is Comment<*> && user.id == subject.createdBy.user.id) {
if (action == Action.UPDATE && user != null && user.id == subject.createdBy.user.id) {
return Vote.GRANTED
}

36
src/test/kotlin/fr/dcproject/security/voter/CommentVoterTest.kt
View File

@@ -108,4 +108,40 @@ internal class CommentVoterTest {
can(CommentVoter.Action.DELETE, it, comment1) `should be` false
}
}
@Test
fun `can be create a comment`() = listOf(CommentVoter()).run {
mockk<ApplicationCall> {
every { user } returns tesla.user
}.let {
can(CommentVoter.Action.CREATE, it, comment1) `should be` true
}
}
@Test
fun `can not be create a comment with other creator`() = listOf(CommentVoter()).run {
mockk<ApplicationCall> {
every { user } returns einstein.user
}.let {
can(CommentVoter.Action.CREATE, it, comment1) `should be` false
}
}
@Test
fun `can not be create a comment if is null`() = listOf(CommentVoter()).run {
mockk<ApplicationCall> {
every { user } returns einstein.user
}.let {
can(CommentVoter.Action.CREATE, it, null) `should be` false
}
}
@Test
fun `can not be create a comment if not connected`() = listOf(CommentVoter()).run {
mockk<ApplicationCall> {
every { user } returns null
}.let {
can(CommentVoter.Action.CREATE, it, comment1) `should be` false
}
}
}